fix: Bump cargo-manifest version to be compatible with 2024 edition workspaces#30
fix: Bump cargo-manifest version to be compatible with 2024 edition workspaces#30lyinch wants to merge 1 commit intoros2-rust:mainfrom
Conversation
|
Do we need to be mindful of building with Rust 1.75? All of our CI builds with the latest stable, so 1.92. I'm going to guess no because we're actually shipping a final binary to users via pip. EDIT: Although I do see this PR which suggests we do care about building for 1.75 for now |
How will this change affect support for 1.75? To me, it looks like we're now just able to parse newer manifests, but the old ones still work. I don't think that the dependency at the new version is incompatible with 1.75. I can see that CI runs with:
so to be sure we'd have to run it with 1.75. |
I have a cargo workspace in which I also want to use rclrs. I am using edition 2024 with resolver v3:
With the current version of
cargo-ament-build, I am getting a parser error:A potential workaround is to not specify the
resolverin this file as it is implicitly defined in the version 2024. However, I still think that this tool should not break existing setups, so this is not a solution for me.cargo-manifestv0.18.0 added support forresolver = "3": https://github.com/LukeMathWalker/cargo-manifest/blob/master/CHANGELOG.md#v0180-2025-01-10, so the proper fix is to bump this dependency. As I am already bumping this dependency version, I opted to use the latest version rather than the lowest one that addresses this issue.Note that I am aware of the failing CI check named
Security audit / security_audit (push)on this dependency, but by sweeping the commits I couldn't find anything sus (e.g. new dependencies), and it seems to be a failing cargo-deny-action run based on this config.This PR resolves the current issue and I can build now with the workspace:
I didn't perform any other tests.
Caveat:
The current
cargo-ament-buildstill doesn't support workspaces (and likely wasn't intended to?) so this PR only resolves one issue with them, but the steps following thecargo buildare still failing:This is out of scope.